Conversation
|
@microsoft-github-policy-service agree |
BillyONeal
left a comment
There was a problem hiding this comment.
Please complete the actual new port checklist rather than making up some other checklist:
- Changes comply with the maintainer guide.
- The packaged project shows strong association with the chosen port name. Check this box if at least one of the following criteria is met:
- The project is in Repology: https://repology.org//versions
- The project is amongst the first web search results for "" or " C++". Include a screenshot of the search engine results in the PR.
- The port name follows the 'GitHubOrg-GitHubRepo' form or equivalent
Owner-Projectform.
- Optional dependencies of the build are all controlled by the port. A dependency is controlled if it is declared an unconditional dependency in
vcpkg.json, or explicitly disabled through patches or build system arguments such as CMAKE_DISABLE_FIND_PACKAGE_Xxx or VCPKG_LOCK_FIND_PACKAGE - The versioning scheme in
vcpkg.jsonmatches what upstream says. - The license declaration in
vcpkg.jsonmatches what upstream says. - The installed as the "copyright" file matches what upstream says.
- The source code of the component installed comes from an authoritative source.
- The generated "usage text" is brief and accurate. See adding-usage for context. Don't add a usage file if the automatically generated usage is correct.
- The version database is fixed by rerunning
./vcpkg x-add-version --alland committing the result. - Exactly one version is added in each modified versions file.
|
See also Hical61#1 |
format-manifest and update version database
|
@BillyONeal Checklist updated and all previous issues fixed. Ready for review. |
BillyONeal
left a comment
There was a problem hiding this comment.
[x] The port name follows the 'GitHubOrg-GitHubRepo' form or equivalent Owner-Project form.
You checked this but it isn't actually true, that form would be hical61-hical. I think things are close enough that we might be able to take that difference under normal conditions, but unfortunately the name "hical" appears to have strong associations with other entities, for example https://www.hical.com/ who make solenoids motors and stuff, https://hical.ca/ who make guns, or the Chinese space agency Hainan International Commercial Aerospace Launch Co., Ltd. ( https://en.wikipedia.org/wiki/HICAL ). And if any of these ever decided to publish a C++ library with us that name being already used would be problematic.
Would you accept naming the port hical61-hical? Note that this is only about what the vcpkg port is named, this isn't an ask to rename your actual project or anything it actually installs.
| @@ -0,0 +1,4 @@ | |||
| hical provides CMake integration targets: | |||
There was a problem hiding this comment.
This usage file is substantially identical to the automatically generated one so we should remove it.
There was a problem hiding this comment.
Agreed, I'll remove the usage file.
@BillyONeal I understand the naming concern. Would |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
Description
Add new port
hicalversion 1.0.1.hical is a modern C++20/C++26 high-performance web framework built on
Boost.Asio/Beast, featuring PMR memory pools, coroutine-based async I/O,
C++20 Concepts, and a C++26 reflection layer.
New Port Checklist
Owner-Projectform.vcpkg.json, or explicitly disabled through patches or build system arguments such as CMAKE_DISABLE_FIND_PACKAGE_Xxx or VCPKG_LOCK_FIND_PACKAGE.vcpkg.jsonmatches what upstream says.vcpkg.jsonmatches what upstream says../vcpkg x-add-version --alland committing the result.